sijie commented on issue #1380: addBookieAndCheckCovered in RRQuorumCoverageSet doesn't work correctly if AcqQuorumSize is greater than (WriteQuorumSize+1)/2 URL: https://github.com/apache/bookkeeper/issues/1380#issuecomment-386413863 > RRQuorumCoverageSet should return true for checkCovered only if all the writesets have atleast AckQuorum number of OKAY responses No. I don't think that is the meaning. The checkConvered here is used for quorum reads not for quorum writes, what you expect here is you should have at least one valid response from every quorum. so the check `nodesNotCovered >= ackQuorumSize` means if I have more "not covered" responses than ackQuorumSize, this quorum didn't see enough responses, the client should fail the quorum reads.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
