sijie commented on issue #1380: addBookieAndCheckCovered in RRQuorumCoverageSet doesn't work correctly if AcqQuorumSize is greater than (WriteQuorumSize+1)/2 URL: https://github.com/apache/bookkeeper/issues/1380#issuecomment-387961241 @jvrao @reddycharan : because the way how bookkeeper writes entries and the lac protocol. we don't really need "quorum" read for reading any entries. that says the coverage here is never designed for a "quorum-read" on entries. so there is no point saying "checkCovered() is not correct". we only need to quorum coverage check for LAC on determining what is the LAC and that is the class designed for. > o as far as ReadLac, we are OK as long as we have one valid response from that write quorum. If that is agreed upon behavior, do we really need a class and checkCovered() response? if the goal is just to read any valid lac, we don't need quorum check; if the goal is to read max valid lac, the quorum check is needed (however I should also say it is not that strongly required). if you look into the API, read any valid lac is tryReadLastAddConfirmed, while read max valid lac is readLastAddConfirmed. Hope this make the question clear.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
