eolivelli commented on issue #1393: BP-14 forceLedger wire protocol server side implementation URL: https://github.com/apache/bookkeeper/pull/1393#issuecomment-387634874 @jvrao the name force superseded "sync" after a quite long discussion between JV,Sijie,Ivan and me and we agreed on that final name. The motivation is that Java APIs use the 'force' verb https://docs.oracle.com/javase/7/docs/api/java/nio/channels/FileChannel.html#force(boolean) on linux we have *fsync*/*fdatasync*, I don't know the windows world but with a quick search I found *fflush*, so using the Java name is more neutral I am open to discussion and decide a new name, from my point of view (coming from Java world and Linux world) every of the two names make sense. So @sijie and @ivankelly were mostly involved in that discussion I I think we need to hear their voices I you feel strong about changing this name.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
