eolivelli commented on issue #1393: BP-14 forceLedger wire protocol server side 
implementation
URL: https://github.com/apache/bookkeeper/pull/1393#issuecomment-387962407
 
 
   @sijie  @jvrao since these "names" (forceLedger vs sync) are only on bare 
code, not on public client API and not on wire protocol, I would like to merge 
this patch now so that bookie side changes are totally in
   this way I can move forwards with steps on client: we cannot merge stuff on 
client if server side stuff is not complete
   
   I can send a follow up change to rename variables and methods if we feel 
strong about changing *force* to *sync*.
   
   Do this sound reasonable to you ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to