jvrao commented on a change in pull request #853: BP-14 WriteFlag DEFERRED_SYNC
Client Side Implementation
URL: https://github.com/apache/bookkeeper/pull/853#discussion_r188505912
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java
##########
@@ -1678,17 +1692,23 @@ void sendAddSuccessCallbacks() {
return;
}
// Check if it is the next entry in the sequence.
- if (pendingAddOp.entryId != 0 && pendingAddOp.entryId !=
lastAddConfirmed + 1) {
Review comment:
You can just keep the same logic here != pendingAddSequenceHead + 1 if you
keep it in sync with LAC in !DEFERRED_SYNC case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
