jvrao commented on a change in pull request #853: BP-14 WriteFlag DEFERRED_SYNC 
Client Side Implementation
URL: https://github.com/apache/bookkeeper/pull/853#discussion_r188506163
 
 

 ##########
 File path: 
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerRecoveryOp.java
 ##########
 @@ -112,6 +112,7 @@ public void readLastConfirmedDataComplete(int rc, 
RecoveryData data) {
                             synchronized (lh) {
                                 lh.lastAddPushed = lh.lastAddConfirmed = 
data.getLastAddConfirmed();
                                 lh.length = data.getLength();
+                                lh.pendingAddsSequenceHead = 
lh.lastAddConfirmed + 1;
 
 Review comment:
   I would like to avoid this logic change; I won't comment on the +1 part for 
the rest of the code.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to