reddycharan commented on a change in pull request #1391: Issue #570: EntryLogManagerForEntryLogPerLedger implementation URL: https://github.com/apache/bookkeeper/pull/1391#discussion_r188808144
########## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogManagerForEntryLogPerLedger.java ########## @@ -0,0 +1,463 @@ +/** + * + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + * + */ + +package org.apache.bookkeeper.bookie; + +import com.google.common.annotations.VisibleForTesting; +import com.google.common.cache.CacheBuilder; +import com.google.common.cache.CacheLoader; +import com.google.common.cache.LoadingCache; +import com.google.common.cache.RemovalListener; +import com.google.common.cache.RemovalNotification; +import io.netty.buffer.ByteBuf; +import java.io.File; +import java.io.IOException; +import java.util.HashMap; +import java.util.HashSet; +import java.util.List; +import java.util.Map; +import java.util.Map.Entry; +import java.util.Optional; +import java.util.Set; +import java.util.concurrent.ConcurrentHashMap; +import java.util.concurrent.ConcurrentMap; +import java.util.concurrent.CopyOnWriteArrayList; +import java.util.concurrent.TimeUnit; +import java.util.concurrent.locks.Lock; +import java.util.concurrent.locks.ReentrantLock; +import lombok.extern.slf4j.Slf4j; +import org.apache.bookkeeper.bookie.EntryLogger.BufferedLogChannel; +import org.apache.bookkeeper.bookie.LedgerDirsManager.LedgerDirsListener; +import org.apache.bookkeeper.conf.ServerConfiguration; +import org.apache.commons.lang.mutable.MutableInt; + +@Slf4j +class EntryLogManagerForEntryLogPerLedger extends EntryLogManagerBase { + + static class EntryLogAndLockTuple { + private final Lock ledgerLock; + private BufferedLogChannel entryLog; + + public EntryLogAndLockTuple() { + ledgerLock = new ReentrantLock(); + } + + public Lock getLedgerLock() { + return ledgerLock; + } + + public BufferedLogChannel getEntryLog() { + return entryLog; + } + + public void setEntryLog(BufferedLogChannel entryLog) { + this.entryLog = entryLog; + } + } + + private LoadingCache<Long, EntryLogAndLockTuple> ledgerIdEntryLogMap; + /* + * every time active logChannel is accessed from ledgerIdEntryLogMap + * cache, the accesstime of that entry is updated. But for certain + * operations we dont want to impact accessTime of the entries (like + * periodic flush of current active logChannels), and those operations + * can use this copy of references. + */ + private final ConcurrentHashMap<Long, BufferedLogChannel> replicaOfCurrentLogChannels; + private final CacheLoader<Long, EntryLogAndLockTuple> entryLogAndLockTupleCacheLoader; + private EntryLogger.RecentEntryLogsStatus recentlyCreatedEntryLogsStatus; Review comment: yes, it can be ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
