reddycharan commented on a change in pull request #1391: Issue #570:
EntryLogManagerForEntryLogPerLedger implementation
URL: https://github.com/apache/bookkeeper/pull/1391#discussion_r188817433
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java
##########
@@ -85,6 +83,7 @@
private final EntryLogMetadata entryLogMetadata;
private final File logFile;
private long ledgerIdAssigned = UNASSIGNED_LEDGERID;
+ volatile boolean ledgerDirFull = false;
Review comment:
Hey Sijie, I considered about your concern before reintroducing this flag
variable here. It would unnecessarily complicate the logic of
LedgerDirsListener for maintaining the ledgerdir full status in the
entrylogmanager implementation. Thats why I chose to keep it here.
I don't think it is inappropriate to have it here, since there is final
'logfile' (File) variable for this BufferedLogChannel here, so I would consider
'ledgerDirFull' variable as extension of 'logFile' variable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
