reddycharan commented on a change in pull request #1391: Issue #570:
EntryLogManagerForEntryLogPerLedger implementation
URL: https://github.com/apache/bookkeeper/pull/1391#discussion_r189074159
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java
##########
@@ -85,6 +83,7 @@
private final EntryLogMetadata entryLogMetadata;
private final File logFile;
private long ledgerIdAssigned = UNASSIGNED_LEDGERID;
+ volatile boolean ledgerDirFull = false;
Review comment:
Considered that as well, having new class BufferedLogChannelWithDirInfo
extending BufferedLogChannelWithDirInfo in EntryLogManagerForEntryLogPerLedger
class. But BufferedLogChannel instance is created by EntryLoggerAllocator
https://github.com/apache/bookkeeper/blob/master/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLoggerAllocator.java#L162
, so if I create new BufferedLogChannelWithDirInfo class, then here I should
have if/else block based on conf value (which I'm not very inclined, but I can
live with it).
is that ok?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
