infodog commented on issue #1509: solve #1476 issue. URL: https://github.com/apache/bookkeeper/pull/1509#issuecomment-396449927 @sijie I think the fix of infodog/bookkeeper#1 may have problem. because `request.complete(rCtx.getBookieIndex(), bookie, buffer, entryId) `will be called even the request is already closed. In request.complete ``` entryImpl.setLength(buffer.getLong(DigestManager.METADATA_LENGTH - 8)); entryImpl.setEntryBuf(content); ``` the entryImpl may already recycled and owned by another request, so this will ruin another request's data? Maybe should move ``` writeSet.recycle(); orderedEnsemble.recycle(); ``` from request.complete to request.close?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
