ivankelly commented on a change in pull request #1809: Change LedgerManager to
use CompletableFuture
URL: https://github.com/apache/bookkeeper/pull/1809#discussion_r233205362
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/CleanupLedgerManager.java
##########
@@ -108,64 +115,69 @@ private GenericCallback removeCallback(GenericCallback
callback) {
return callbacks.remove(callback);
}
+ private void recordPromise(CompletableFuture<?> promise) {
Review comment:
Are you saying the underlying LM should keep track of all futures they
return?
This change is to basically do the same thing as the CleanupLedgerManager
did for callbacks. i.e. If close is called, all outstanding futures should be
closed, and all future calls also closed. Moving this into the underlying LM
would basically mean making an AbstractLM with this recordPromise and pulling
that into the other LMs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
