ivankelly commented on a change in pull request #1809: Change LedgerManager to
use CompletableFuture
URL: https://github.com/apache/bookkeeper/pull/1809#discussion_r234209071
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/CleanupLedgerManager.java
##########
@@ -108,64 +115,69 @@ private GenericCallback removeCallback(GenericCallback
callback) {
return callbacks.remove(callback);
}
+ private void recordPromise(CompletableFuture<?> promise) {
Review comment:
the underlying implementations don't handle it though. for them to handle
it, each would have to have this recording logic. so it's cleaner to have it
abstracted somewhere else.
The reason I did it in this patch is so this patch doesn't remove
functionality. Currently, the cleanup lm ensures that if the lm is closed, then
all outstanding requests are completed. If we don't implement this here, then
this functionality is lost.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
