sijie commented on a change in pull request #1809: Change LedgerManager to use
CompletableFuture
URL: https://github.com/apache/bookkeeper/pull/1809#discussion_r233207589
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/CleanupLedgerManager.java
##########
@@ -108,64 +115,69 @@ private GenericCallback removeCallback(GenericCallback
callback) {
return callbacks.remove(callback);
}
+ private void recordPromise(CompletableFuture<?> promise) {
Review comment:
No, what I mean is underlying implementation will probably already handle
that. we don't need to worry about that at this layer.
it is a good feature to have at any case. but let's do it in a separate PR
rather than doing it in a large refactor.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
