jvrao commented on a change in pull request #1902: (WIP) Metadata checker
validating EnsemblePlacementpolicy
URL: https://github.com/apache/bookkeeper/pull/1902#discussion_r248538982
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKeeperAdmin.java
##########
@@ -1643,4 +1643,24 @@ private static boolean
areEntriesOfSegmentStoredInTheBookie(LedgerMetadata ledge
}
return firstStoredEntryId != LedgerHandle.INVALID_ENTRY_ID;
}
+
+ /**
+ * returns boolean value specifying if the ensemble of the segment is
+ * adhering to the ensemble placement policy for the given writeQuorumSize
+ * and ackQuorumSize.
+ *
+ * @param ensembleList
+ * ensemble of the segment
Review comment:
ensembleList confused me as if it is a list of ensembles. May be you should
consider renaming it to ensembleBookiesList or something
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
