jvrao commented on a change in pull request #1902: (WIP) Metadata checker
validating EnsemblePlacementpolicy
URL: https://github.com/apache/bookkeeper/pull/1902#discussion_r248542187
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/ServerConfiguration.java
##########
@@ -2188,6 +2189,29 @@ public long getAuditorPeriodicBookieCheckInterval() {
return getLong(AUDITOR_PERIODIC_BOOKIE_CHECK_INTERVAL, 86400);
}
+ /**
+ * Set the regularity at which the auditor will run a metadata check of all
+ * write closed/fenced ledgers. This should not be run very often, and at
+ * most, once a day. Setting this to 0 will completely disable the periodic
+ * metadata check.
Review comment:
You are calling this metadata check; but we thought of having two parts of
this mestadata check 1. Ensemble placement Check 2. Bookie data / metadata
cross verification check, they both comprise of metadata check. So I would
consider giving that clarity in variables/tunable/method names.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
