reddycharan commented on a change in pull request #1902: (WIP) Metadata checker
validating EnsemblePlacementpolicy
URL: https://github.com/apache/bookkeeper/pull/1902#discussion_r248773351
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/replication/Auditor.java
##########
@@ -161,6 +174,12 @@
help = "the number of delayed-bookie-audits cancelled"
)
private final Counter numDelayedBookieAuditsCancelled;
+ @StatsDoc(
+ name =
METADATA_CHECK_ENSEMBLE_NOT_ADHERING_TO_PLACEMENT_POLICY_COUNTER,
+ help = "total number of "
+ + "segments of ledgers failed to adhere to EnsemblePlacementPolicy
found in metadata check"
+ )
Review comment:
by definition ensemble of bookies is associated to segment, so I opted for
per segment. Being said that I see point in your concern. Probably its best to
log for each segment failure and have metric per ledger.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
