reddycharan commented on a change in pull request #1902: (WIP) Metadata checker
validating EnsemblePlacementpolicy
URL: https://github.com/apache/bookkeeper/pull/1902#discussion_r248797738
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKeeperAdmin.java
##########
@@ -1643,4 +1643,24 @@ private static boolean
areEntriesOfSegmentStoredInTheBookie(LedgerMetadata ledge
}
return firstStoredEntryId != LedgerHandle.INVALID_ENTRY_ID;
}
+
+ /**
+ * returns boolean value specifying if the ensemble of the segment is
+ * adhering to the ensemble placement policy for the given writeQuorumSize
+ * and ackQuorumSize.
+ *
+ * @param ensembleList
+ * ensemble of the segment
+ * @param writeQuorumSize
+ * writeQuorumSize of the ledger
+ * @param ackQuorumSize
+ * ackQuorumSize of the ledger
+ * @return <tt>true</tt> if the ledger is adhering to
+ * EnsemblePlacementPolicy
+ */
+ public boolean
isEnsembleAdheringToPlacementPolicy(List<BookieSocketAddress> ensembleList, int
writeQuorumSize,
Review comment:
isEnsembleAdheringToPlacementPolicy method name is already used in
EnsemblePlacementPolicy, so continuing to use it. Also, 'adhere' sounds more
appropriate.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
