athanatos commented on a change in pull request #1931: (WIP)
GetListOfEntriesOfLedger implementation
URL: https://github.com/apache/bookkeeper/pull/1931#discussion_r253230077
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/SortedLedgerStorage.java
##########
@@ -354,4 +355,10 @@ public boolean isInForceGC() {
public List<GarbageCollectionStatus> getGarbageCollectionStatus() {
return interleavedLedgerStorage.getGarbageCollectionStatus();
}
+
+ @Override
+ public byte[] getEntriesOfLedger(long ledgerId) throws Exception {
Review comment:
See: this shouldn't return a byte[] -- it should return an iterator
representing the merged streams from the memtable and interleavedLedgerStorage.
The caller should be responsible for encoding it before it gets sent back.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
