athanatos commented on a change in pull request #1931: (WIP)
GetListOfEntriesOfLedger implementation
URL: https://github.com/apache/bookkeeper/pull/1931#discussion_r253230248
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/storage/ldb/DbLedgerStorage.java
##########
@@ -335,4 +335,10 @@ public boolean isInForceGC() {
return ledgerStorageList.stream()
.map(single ->
single.getGarbageCollectionStatus().get(0)).collect(Collectors.toList());
}
+
+ @Override
+ public byte[] getEntriesOfLedger(long ledgerId) {
+ // TODO Auto-generated method stub
+ return null;
Review comment:
An error code would suffice -- getEntriesOfLedger should therefore be able
to raise a NotImplemented exception or whatever is most idiomatic.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
