eolivelli commented on a change in pull request #2166: Enhance
deferLedgerLockReleaseOfFailedLedger in ReplicationWorker
URL: https://github.com/apache/bookkeeper/pull/2166#discussion_r327340667
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerFragmentReplicator.java
##########
@@ -328,6 +334,9 @@ public void readComplete(int rc, LedgerHandle lh,
if (rc != BKException.Code.OK) {
LOG.error("BK error reading ledger entry: " + entryId,
BKException.create(rc));
+ if (entriesUnableToReadForThisLedger != null) {
Review comment:
I would require that this variable is already non null, in order to not miss
any possible code path that reaches this point
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
