eolivelli commented on a change in pull request #2166: Enhance
deferLedgerLockReleaseOfFailedLedger in ReplicationWorker
URL: https://github.com/apache/bookkeeper/pull/2166#discussion_r329635414
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKeeperAdmin.java
##########
@@ -95,6 +96,7 @@
private static final Logger LOG =
LoggerFactory.getLogger(BookKeeperAdmin.class);
private static final Logger VERBOSE = LoggerFactory.getLogger("verbose");
+ public static final BiConsumer<Long, Long> NOOP_BICONSUMER = (l, e) -> { };
Review comment:
I prefer not to add such kind of generic constants to a public API
(BookKeeperAdmin is used on downstream projects).
can you please move it in some Utility class in tests ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
