karanmehta93 commented on a change in pull request #2173: Call exceptionHandler
if Bookie.start fails with exception.
URL: https://github.com/apache/bookkeeper/pull/2173#discussion_r333245010
##########
File path:
bookkeeper-common/src/main/java/org/apache/bookkeeper/common/component/ComponentStarter.java
##########
@@ -72,6 +73,8 @@ public void run() {
// register a component exception handler
component.setExceptionHandler((t, e) -> {
+ log.error("Triggered exceptionHandler of Component: {} because of
Exception in Thread: {}",
Review comment:
Since we hook up exception handler on every component, in case if multiple
of them fail, we might see IllegalStateException when we try to start a thread
which is already started.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
