karanmehta93 commented on a change in pull request #2173: Call exceptionHandler
if Bookie.start fails with exception.
URL: https://github.com/apache/bookkeeper/pull/2173#discussion_r333348453
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/server/service/AutoRecoveryService.java
##########
@@ -56,8 +59,14 @@ public AutoRecoveryMain getAutoRecoveryServer() {
protected void doStart() {
try {
this.main.start();
- } catch (UnavailableException e) {
- throw new RuntimeException("Can't not start '" + NAME + "'
component.", e);
+ } catch (Throwable exc) {
+ LOG.error("Got unexpected exception while starting
AutoRecoveryMain", exc);
Review comment:
Lets move this to AbstractLifecycle#start() method, since exceptions can
happen in any component start.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
