reddycharan commented on a change in pull request #2182: Add API for Bookie
checksum verification writeFlags
URL: https://github.com/apache/bookkeeper/pull/2182#discussion_r336285960
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/api/WriteFlag.java
##########
@@ -57,10 +77,20 @@
* @return a set of flags
*/
public static EnumSet<WriteFlag> getWriteFlags(int flagValue) {
+ EnumSet<WriteFlag> writeFlags = EnumSet.noneOf(WriteFlag.class);
if ((flagValue & DEFERRED_SYNC.value) == DEFERRED_SYNC.value) {
- return ONLY_DEFERRED_SYNC;
+ writeFlags.add(DEFERRED_SYNC);
+ }
+ if ((flagValue & DIGEST_TYPE_DUMMY.value) == DIGEST_TYPE_DUMMY.value) {
Review comment:
Btw what if in this 'flagValue' int multiple digesttypes are enabled? How do
we handle this error scenario?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
