atris commented on issue #2257: 2178: IOException Should Be Thrown When Journal Is Corrupted URL: https://github.com/apache/bookkeeper/pull/2257#issuecomment-584801825 The issue there would be that the RandomFileAccess instance used to create the FileChannel is also created in the same context so we will probably have to powermock up the call stack. I felt this way is a longer term way to test different cases of FileChannel implementations especially since FileChannel is an external class not owned by our codebase. Thoughts? -- Regards, Atri *l'apprenant*
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
