eolivelli commented on a change in pull request #2257: 2178: IOException Should
Be Thrown When Journal Is Corrupted
URL: https://github.com/apache/bookkeeper/pull/2257#discussion_r378672533
##########
File path:
bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/BookieJournalTest.java
##########
@@ -794,4 +801,50 @@ private void testPartialFileInfoPostV3Journal(boolean
truncateMasterKey)
// correct behaviour
}
}
+
+ @Test(expected = IOException.class)
Review comment:
Is is too ambiguous.
We ate not sure that only the last line threw this exception.
Please move the assertion exactly around the expected invocation
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
