eolivelli commented on a change in pull request #1949: [bookie-gc] add option
to cache entry-log metadata map into rocksDB
URL: https://github.com/apache/bookkeeper/pull/1949#discussion_r392799809
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/GarbageCollectorThread.java
##########
@@ -127,35 +127,41 @@ public GarbageCollectorThread(ServerConfiguration conf,
LedgerManager ledgerMana
Executors.newSingleThreadScheduledExecutor(new
DefaultThreadFactory("GarbageCollectorThread")));
}
+ private EntryLogMetadataMap createEntryLogMetadataMap(boolean
gcPersistentEntrylogMetadataMapEnabled) {
+ final String baseDir =
this.entryLogger.getLedgerDirsManager().getAllLedgerDirs().get(0).toString();
+ try {
+ if (gcPersistentEntrylogMetadataMapEnabled) {
+ return new PersistentEntryLogMetadataMap(baseDir, conf);
+ }
+ } catch (IOException e) {
+ LOG.error("Failed to initialize persistent-metadata-map , clean up
{}", baseDir, e);
Review comment:
This comment looks unresolved
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
