lamber-ken opened a new pull request #2331:
URL: https://github.com/apache/bookkeeper/pull/2331


   ### Motivation
   
   **Code clean**
   
   - An overridden method should be marked with @Override annotation, once the 
method signature in the abstract class is changed, the implementation class 
will report a compile-time error immediately.
   
   - Exception class names must be ended with Exception
   
   - The negation operator is not easy to be quickly understood
   
   ### Changes
   
   - Fix missing `@Override` annotation
   - `NoIndexForLedger` to `NoIndexForLedgerException` 
   - `!(n.doubleValue() > max.doubleValue())` to `n.doubleValue() < 
max.doubleValue()`
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to