lamber-ken commented on pull request #2331: URL: https://github.com/apache/bookkeeper/pull/2331#issuecomment-629770830
Thanks for your review @eolivelli > Do you think that we can add a checkstyle rule? Sure, but from the checkstyle official docs, can not found a useful checkstyle rule. https://checkstyle.sourceforge.io/checks.html https://checkstyle.sourceforge.io/config_annotation.html#MissingOverride > CI failed I checked the ci error exception stackstrace, it seems doesn't caused by my modification. If you have, help to check it, thanks ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
