eolivelli commented on issue #2482: URL: https://github.com/apache/bookkeeper/issues/2482#issuecomment-725417188
@RaulGracia do you see this behavior out of docker/k8s ? `Another question regarding the logic of the Bookkeeper client itself is: should the client attempt to re-create the channel always that a client/read/write timeout is detected? Such timeouts are in the configuration of the Bookkeeper client and I wonder if something could be done in the presence of such events to re-resolve the Bookie IP.` In current master we are creating a new SocketAddress per each connection trial https://github.com/apache/bookkeeper/blob/master/bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/PerChannelBookieClient.java#L602 https://github.com/apache/bookkeeper/blob/master/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/DefaultBookieAddressResolver.java#L49 but also in pre-4.12 code we are recreating it every time (IIRC this code is there from 4.8 or before, when people started deploying BK on K8s) https://github.com/apache/bookkeeper/blob/master/bookkeeper-server/src/main/java/org/apache/bookkeeper/net/BookieSocketAddress.java#L98 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
