fpj commented on a change in pull request #2761:
URL: https://github.com/apache/bookkeeper/pull/2761#discussion_r687629434
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/PerChannelBookieClient.java
##########
@@ -540,6 +541,8 @@ protected ChannelFuture connect() {
bootstrap.group(eventLoopGroup);
if (eventLoopGroup instanceof EpollEventLoopGroup) {
bootstrap.channel(EpollSocketChannel.class);
+ // For Epoll, also set the connection timeout via TCP_USER_TIMEOUT.
+ bootstrap.option(EpollChannelOption.TCP_USER_TIMEOUT,
conf.getClientConnectTimeoutMillis());
Review comment:
It sounds right to add it here, but I don't really like the idea of
reusing the configuration parameter. That has a different purpose. I'd say it
is fine to add a configuration parameter. For a new configuration parameter, we
can either have a default or not set it in the case the configuration does not
include a value for it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
