fpj commented on a change in pull request #2761:
URL: https://github.com/apache/bookkeeper/pull/2761#discussion_r691120423
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/PerChannelBookieClient.java
##########
@@ -540,6 +541,8 @@ protected ChannelFuture connect() {
bootstrap.group(eventLoopGroup);
if (eventLoopGroup instanceof EpollEventLoopGroup) {
bootstrap.channel(EpollSocketChannel.class);
+ // For Epoll channels, we can set the TCP user timeout.
+ bootstrap.option(EpollChannelOption.TCP_USER_TIMEOUT,
conf.getTcpUserTimeoutMillis());
Review comment:
If the configuration option isn't set, then I'd rather not set a value.
According to the RFC (https://datatracker.ietf.org/doc/html/rfc5482):
> In the absence of an application-specified user timeout, the TCP
specification [RFC0793] defines a default user timeout of 5 minutes.
I'd leave it to the system defaults.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
