Sunny-Island commented on a change in pull request #2742:
URL: https://github.com/apache/bookkeeper/pull/2742#discussion_r689234993
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/JournalChannel.java
##########
@@ -85,37 +86,41 @@
// The position of the file channel's last drop position
private long lastDropPosition = 0L;
+ final ServerConfiguration configuration;
+
// Mostly used by tests
JournalChannel(File journalDirectory, long logId) throws IOException {
- this(journalDirectory, logId, 4 * 1024 * 1024, 65536, START_OF_FILE);
+ this(journalDirectory, logId, 4 * 1024 * 1024, 65536, START_OF_FILE,
new ServerConfiguration());
Review comment:
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
