eolivelli commented on pull request #2742: URL: https://github.com/apache/bookkeeper/pull/2742#issuecomment-903504157
@zymap is there a particular reason why you are not adding a close() method to `FileChannelProvider` (you can make it extend Closable or AutoCloseable) ? For instance if the `FileChannelProvider` implements some kind of resource pooling or needs some procedure for a graceful shutdown currently there is no way to implement it. Adding a `close() ` method is very easy and it will make like easier for implementors of `FileChannelProvider` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
