gaozhangmin commented on a change in pull request #2805:
URL: https://github.com/apache/bookkeeper/pull/2805#discussion_r717525589
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/replication/Auditor.java
##########
@@ -998,6 +1006,13 @@ public void run() {
}), initialDelay, interval, TimeUnit.SECONDS);
}
+ private class UnderReplicatedLedgersChangedCb implements
GenericCallback<Void> {
+ @Override
+ public void operationComplete(int rc, Void result) {
+ numUnderReplicatedLedger.registerSuccessfulValue(-1);
Review comment:
I added three new metrics. `UNDER_REPLICATED_LEDGERS_COUNT
UNDER_REPLICATED_LEDGERS_SIZE REPLICATED_LEDGERS_COUNT`
previous metrics are named `NUM_UNDER_REPLICATED_LEDGERS
UNDER_REPLICATED_LEDGERS_TOTAL_SIZE`
I prefer to delete the previous OpStatsLogger metrics. so only
`REPLICATED_LEDGERS_COUNT` will be added.
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/replication/Auditor.java
##########
@@ -998,6 +1006,13 @@ public void run() {
}), initialDelay, interval, TimeUnit.SECONDS);
}
+ private class UnderReplicatedLedgersChangedCb implements
GenericCallback<Void> {
+ @Override
+ public void operationComplete(int rc, Void result) {
+ numUnderReplicatedLedger.registerSuccessfulValue(-1);
Review comment:
@dlg99
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
