eolivelli commented on a change in pull request #2805:
URL: https://github.com/apache/bookkeeper/pull/2805#discussion_r722035840
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/ZkLedgerUnderreplicationManager.java
##########
@@ -854,6 +855,28 @@ public int getLostBookieRecoveryDelay() throws
UnavailableException {
}
}
+ @Override
+ public void notifyUnderReplicationLedgerChanged(GenericCallback<Void> cb)
throws UnavailableException {
+ LOG.debug("notifyUnderReplicationLedgerChanged()");
+ Watcher w = new Watcher() {
+ @Override
+ public void process(WatchedEvent e) {
+ if (e.getType() == Event.EventType.NodeDeleted &&
idExtractionPattern.matcher(e.getPath()).find()) {
+ cb.operationComplete(0, null);
+ }
+ }
+ };
+ try {
+ zkc.addWatch(urLedgerPath, w, AddWatchMode.PERSISTENT_RECURSIVE);
Review comment:
this mode requires ZooKeeper 3.6 - PERSISTENT_RECURSIVE
This is a breaking change.
I believe that this is fine for most of the users nowadays, but we have to
say in the release notes that now BookKeeper will work only with ZooKeeper 3.6.x
cc @sijie @fpj @merlimat @jvrao
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
