mauricebarnum commented on a change in pull request #2814:
URL: https://github.com/apache/bookkeeper/pull/2814#discussion_r723542948
##########
File path: circe-checksum/build.gradle
##########
@@ -34,8 +34,8 @@ task generateJniHeaders(type:Exec) {
}
dependsOn classes
def classpath = sourceSets.main.output.classesDirs.join(":")
- commandLine("javah", "-d", javahOutputDir, "-classpath",
- classpath, "com.scurrilous.circe.crc.Sse42Crc32C")
+ commandLine("javac", "-h", javahOutputDir, "-classpath",
Review comment:
fwiw, gradle has first class support for JNI headers now. i didn't
check the version, and i don't know gradle well enough yet to update the
dependencies for the shared objects.
https://docs.gradle.org/current/dsl/org.gradle.api.tasks.compile.CompileOptions.html#org.gradle.api.tasks.compile.CompileOptions:headerOutputDirectory
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
