pradeepbn commented on a change in pull request #2814:
URL: https://github.com/apache/bookkeeper/pull/2814#discussion_r723736860
##########
File path: circe-checksum/build.gradle
##########
@@ -34,8 +34,8 @@ task generateJniHeaders(type:Exec) {
}
dependsOn classes
def classpath = sourceSets.main.output.classesDirs.join(":")
- commandLine("javah", "-d", javahOutputDir, "-classpath",
- classpath, "com.scurrilous.circe.crc.Sse42Crc32C")
+ commandLine("javac", "-h", javahOutputDir, "-classpath",
Review comment:
Yes, totally agree @mauricebarnum and made relevant changes in another
PR #2817. I will close this PR since this is based on @pkumar-singh PR #2812
and want to keep it independent of #2812 changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
