Vanlightly commented on pull request #2860: URL: https://github.com/apache/bookkeeper/pull/2860#issuecomment-952634933
I don't think we necessarily need a new exception type here. For one, the CacheFlushTimeoutException makes assumptions about the ledger storage engine having a cache whose flush can timeout which isn't necessarily always going to be true. The point the exception needs to convey is that the storage engine has rejected the request as it is too busy already. The existing OperationRejectedException does have an incorrect description as it has nothing to do with fenced ledgers and there is an exception for that already. I would either change the name of the CacheFlushTimeoutException to something like StorageTooBusyException or simply keep the existing OperationRejectedException, and change the javadoc to state that the exception is thrown by a component that is too busy to accept the request. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
