pradeepbn edited a comment on pull request #2860:
URL: https://github.com/apache/bookkeeper/pull/2860#issuecomment-953361896
@eolivelli thanks for your review/ comment. I tried adding a unit test using
mockito which is a non-trivial change for this kind of fix. Also, thought about
adding an integration test but it will be very complicated to reproduce this
scenario in integration tests e.g, slow disk storage of some sort. Furthermore,
there are many status codes (about 10) for which tests are non-existent at this
point. Wondering if you are Ok to skip this with a no-test?
This is only used from SingleDirectoryDbLedgerStorage which is called from
WriteEntryProcessV3. So, it should be a non-issue for V2 wire protocol handler?
Please let me know if I missing something.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
