pkumar-singh commented on a change in pull request #2868:
URL: https://github.com/apache/bookkeeper/pull/2868#discussion_r741561133



##########
File path: stream/bk-grpc-name-resolver/build.gradle
##########
@@ -29,6 +29,7 @@ dependencies {
     implementation project(':stream:common')
     implementation depLibs.grpc
     implementation depLibs.slf4j
+    implementation depLibs.log4jSlf4jImpl

Review comment:
       Consider change this to testImplementation, If they are only referenced 
in tests?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to