pkumar-singh commented on pull request #2868: URL: https://github.com/apache/bookkeeper/pull/2868#issuecomment-956654516
A very general comment. I think here, there is no need to use volatile as well as lock. In fact since access to isStorageShutdown is always under a lock. You might as well drop volatile keyword. Just a thought. Else looks good to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
