eolivelli commented on a change in pull request #2888:
URL: https://github.com/apache/bookkeeper/pull/2888#discussion_r754096440
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/PacketProcessorBaseV3.java
##########
@@ -87,25 +87,26 @@ protected void sendResponse(StatusCode code, Object
response, OpStatsLogger stat
requestProcessor.invalidateBlacklist(channel);
}
}
-
- channel.writeAndFlush(response).addListener(new
ChannelFutureListener() {
- @Override
- public void operationComplete(ChannelFuture future) throws
Exception {
- long writeElapsedNanos = MathUtils.elapsedNanos(writeNanos);
- if (!future.isSuccess()) {
- requestProcessor.getRequestStats().getChannelWriteStats()
- .registerFailedEvent(writeElapsedNanos,
TimeUnit.NANOSECONDS);
- } else {
- requestProcessor.getRequestStats().getChannelWriteStats()
- .registerSuccessfulEvent(writeElapsedNanos,
TimeUnit.NANOSECONDS);
- }
- if (StatusCode.EOK == code) {
-
statsLogger.registerSuccessfulEvent(MathUtils.elapsedNanos(enqueueNanos),
TimeUnit.NANOSECONDS);
- } else {
-
statsLogger.registerFailedEvent(MathUtils.elapsedNanos(enqueueNanos),
TimeUnit.NANOSECONDS);
+ if (channel.isActive()) {
Review comment:
what about adding a "ELSE" branch with a log message ?
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/PacketProcessorBase.java
##########
@@ -66,7 +66,9 @@ protected boolean isVersionCompatible() {
}
protected void sendResponse(int rc, Object response, OpStatsLogger
statsLogger) {
- channel.writeAndFlush(response, channel.voidPromise());
+ if (channel.isActive()) {
Review comment:
what about adding a "ELSE" branch with a log message ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
