Vanlightly commented on a change in pull request #2888:
URL: https://github.com/apache/bookkeeper/pull/2888#discussion_r755094781
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/PacketProcessorBase.java
##########
@@ -66,7 +66,9 @@ protected boolean isVersionCompatible() {
}
protected void sendResponse(int rc, Object response, OpStatsLogger
statsLogger) {
- channel.writeAndFlush(response, channel.voidPromise());
+ if (channel.isActive()) {
Review comment:
This is a controlled exception within Netty but it will pollute the log
during shutdown. So I think that's its worth keeping the IF statement. What do
you think @eolivelli?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
