eolivelli commented on a change in pull request #2888:
URL: https://github.com/apache/bookkeeper/pull/2888#discussion_r759010938
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/PacketProcessorBase.java
##########
@@ -66,7 +66,11 @@ protected boolean isVersionCompatible() {
}
protected void sendResponse(int rc, Object response, OpStatsLogger
statsLogger) {
- channel.writeAndFlush(response, channel.voidPromise());
+ if (channel.isActive()) {
+ channel.writeAndFlush(response, channel.voidPromise());
+ } else {
+ LOGGER.info("Netty channel is inactive, hence bypassing netty
channel writeAndFlush during sendResponse");
Review comment:
please report the channel(), it will bring useful information about the
client that won't receive the response.
please use "debug" and not "info"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
