hangc0276 commented on code in PR #3248:
URL: https://github.com/apache/bookkeeper/pull/3248#discussion_r905784640
##########
bookkeeper-server/src/test/java/org/apache/bookkeeper/client/TestRegionAwareEnsemblePlacementPolicy.java:
##########
@@ -1208,16 +1208,31 @@ private void
prepareNetworkTopologyForReorderTests(String myRegion) throws Excep
@Test
public void testBasicReorderReadSequenceWithLocalRegion() throws Exception
{
+ prepareNetworkTopologyForReorderTests("region2");
basicReorderReadSequenceWithLocalRegionTest("region2", false);
}
@Test
public void testBasicReorderReadLACSequenceWithLocalRegion() throws
Exception {
+ prepareNetworkTopologyForReorderTests("region2");
Review Comment:
We should both test read and write.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
