wangjialing218 commented on code in PR #3248:
URL: https://github.com/apache/bookkeeper/pull/3248#discussion_r930570545


##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/RegionAwareEnsemblePlacementPolicy.java:
##########
@@ -173,6 +174,10 @@ public RegionAwareEnsemblePlacementPolicy 
initialize(ClientConfiguration conf,
         super.initialize(conf, optionalDnsResolver, timer, featureProvider, 
statsLogger, bookieAddressResolver)
                 .withDefaultRack(NetworkTopology.DEFAULT_REGION_AND_RACK);
         myRegion = getLocalRegion(localNode);
+        String localRegion = conf.getString(REPP_LOCAL_REGION, null);

Review Comment:
   I'm not sure whether  `throwExceptionOnMissing` could be set true in some 
condition.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to