hangc0276 commented on code in PR #3214:
URL: https://github.com/apache/bookkeeper/pull/3214#discussion_r905964413
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/ServerConfiguration.java:
##########
@@ -213,7 +213,7 @@ public class ServerConfiguration extends
AbstractConfiguration<ServerConfigurati
"auditorMaxNumberOfConcurrentOpenLedgerOperations";
protected static final String
AUDITOR_ACQUIRE_CONCURRENT_OPEN_LEDGER_OPERATIONS_TIMEOUT_MSEC =
"auditorAcquireConcurrentOpenLedgerOperationsTimeOutMSec";
- protected static final String IN_FLIGHT_READ_ENTRY_NUM_IN_LEDGER_CHECKER =
"inFlightReadEntryNumInLedgerChecker";
+ protected static final String READ_ENTRY_RATE_IN_LEDGER_CHECKER =
"readEntryRateInLedgerChecker";
Review Comment:
The PR https://github.com/apache/bookkeeper/pull/2973 has been released in
BookKeeper 4.15.0, we'd better mark the old one as deprecated instead of
removing it. And set the old value to the new one if the user sets the old one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
