rdhabalia commented on PR #3214: URL: https://github.com/apache/bookkeeper/pull/3214#issuecomment-1211526187
I think the main issue is #2973 implementation. You should not add a blocking call to throttle unless you have sync API. The right fix for #2973 is to check the permit and if the process doesn't have a permit then schedule a task to retry and check the permit rather blocking the thread. so, we should have added `tryAcquire()` instead of blocking `acquire()`. with that fix we won't have thread issues and also will not require the extra threads. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
