gaozhangmin commented on code in PR #3353:
URL: https://github.com/apache/bookkeeper/pull/3353#discussion_r908217953
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/SyncThread.java:
##########
@@ -133,7 +133,7 @@ public Future requestFlush() {
private void flush() {
Checkpoint checkpoint = checkpointSource.newCheckpoint();
Review Comment:
Any suggestion? We just remove
`checkpointSource.checkpointComplete(checkpoint, false);` here?
But the parameter `disableCheckpoint ` won't take effect any more.
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/SyncThread.java:
##########
@@ -133,7 +133,7 @@ public Future requestFlush() {
private void flush() {
Checkpoint checkpoint = checkpointSource.newCheckpoint();
Review Comment:
Any suggestion? We just remove
`checkpointSource.checkpointComplete(checkpoint, false);` here?
But the parameter `disableCheckpoint ` won't take effect any more.
@hangc0276
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
